Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] make ikfastpy link to @LAPACK_LIBRARIES@ #771

Open
wants to merge 3 commits into
base: production
Choose a base branch
from
Open

[WIP] make ikfastpy link to @LAPACK_LIBRARIES@ #771

wants to merge 3 commits into from

Conversation

cielavenir
Copy link
Collaborator

caveats: we will not able to share iksolver if CMAKE_INSTALL_PREFIX is different (you know what I mean actually).

@rdiankov
Copy link
Owner

@cielavenir why don't you put find_package(LAPACK) in the root CMakeLists.txt?

@rdiankov
Copy link
Owner

@cielavenir can you move find_package(LAPACK) to the root CMakeLists.txt?

@cielavenir cielavenir changed the title make ikfastpy link to @LAPACK_LIBRARIES@ [WIP] make ikfastpy link to @LAPACK_LIBRARIES@ Mar 30, 2020
@cielavenir
Copy link
Collaborator Author

WIP until our liblapack policy is firmly settled. We are aware that building dynamic-linked so fails when find_package(LAPACK) selects MKL.

@cielavenir
Copy link
Collaborator Author

[to track the issue properly] related comment https://gitlab.kitware.com/cmake/cmake/-/issues/20491#note_719552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdiankov rdiankov Awaiting requested review from rdiankov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cielavenir @rdiankov